Note that frozendict is also a hashed collection that invokes the __hash__ method of objects in data model documentation #148867
Open
jonathandung wants to merge 2 commits intopython:mainfrom
Open
Note that frozendict is also a hashed collection that invokes the __hash__ method of objects in data model documentation #148867jonathandung wants to merge 2 commits intopython:mainfrom
frozendict is also a hashed collection that invokes the __hash__ method of objects in data model documentation #148867jonathandung wants to merge 2 commits intopython:mainfrom
Conversation
bedevere-app
Bot
added
awaiting review
docs
Contributor
Author
|
Please add skip issue. |
johnslavik
requested changes
Apr 22, 2026
johnslavik
approved these changes
Apr 22, 2026
ZeroIntensity
requested changes
Apr 22, 2026
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Please fix the Oxford comma change, per @johnslavik's suggestion, and then I'll happily merge this.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portion of the data model page documenting
object.__hash__currently acknowledges that besides the built-inhashfunction, 'operations on members of hashed collections includingset,frozensetanddict' would also call__hash__. That list should be expanded in light of 3.15 implementingfrozendict, which also falls into this category.📚 Documentation preview 📚: https://cpython-previews--148867.org.readthedocs.build/